Applied safe linting suggestions #2155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
approved these changes
Dec 23, 2023
fenhl
requested changes
Jan 25, 2024
| @@ -1,7 +1,7 @@ | |||
| from __future__ import annotations | |||
| import random | |||
| import sys | |||
| from collections.abc import Callable, Sequence | |||
| from collections.abc import Sequence | |||
There was a problem hiding this comment.
Upon re-reviewing, I noticed that you removed this import which is used in type aliases in lines 19 and 20. We should probably run a type checker as part of CI to catch errors like this. There may be other similar ones in this PR, haven't gone through everything yet.
fenhl
added
Status: Waiting for Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.