Include key total in item get text box #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuphat
added
Component: ASM/C
|
This doesn't seem to be functioning currently, pictured is the 3rd fire temple small key picked up |
|
Fixed.
|
fenhl
force-pushed
the
total-small-key-count-text-boxes
branch
from
81f179a to
b004c11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1563, the game started tracking the total number of small keys collected for a dungeon for display in the pause menu. Originally also planned as part of that PR was displaying this number in the get item text boxes for small keys. This was achieved by adding a different text box for each possible combination of count and dungeon. However, this ultimately turned out to be more text than could fit into the memory reserved for text — an issue that was tracked as #1572 — and the PR was merged without any changes to text boxes. Now that that issue has been fixed by #1837, this PR reintroduces the key count to the text boxes. This iteration has also been fixed to work with gold skulltula and collectible locations.