Don't count dungeons with rewards on altar as already hinted #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue described here: <https://discord.com/channels/274180765816848384/438698093354156032/1027371049215594526> tl;dr: Hint areas with an already hinted location can't be hinted barren. An exception is made for always hints but not for altar hints, so dungeons currently can't be hinted barren. Making altar hints work like always hints would only fix this until dungeon rewards become major items (which is necessary for dungeon reward shuffle), so instead this is fixed by specifically making the “already hinted” check for barren hints ignore boss locations.
cjohnson57
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described here: https://discord.com/channels/274180765816848384/438698093354156032/1027371049215594526
tl;dr: Hint areas with an already hinted location can't be hinted barren. An exception is made for always hints but not for altar hints, so dungeons currently can't be hinted barren. Making altar hints work like always hints would only fix this until dungeon rewards become major items (which is planned for dungeon reward shuffle), so instead this is fixed by specifically making the “already hinted” check for barren hints ignore boss locations.