Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure boss rooms are added to regions for 1 major per dungeon #1683

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Ensure boss rooms are added to regions for 1 major per dungeon #1683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Fill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,15 @@ def fill_dungeon_unique_item(window, worlds, search, fill_locations, itempool):

# iterate of all the dungeons in a random order, placing the item there
for dungeon in dungeons:
dungeon_locations = [location for region in dungeon.regions for location in region.locations if location in fill_locations]
# Need to re-get dungeon regions to ensure boss rooms are considered
regions = []
for region in dungeon.world.regions:
try:
if HintArea.at(region).dungeon_name == dungeon.name:
regions.append(region)
except:
pass
dungeon_locations = [location for region in regions for location in region.locations if location in fill_locations]

# cache this list to flag afterwards
all_dungeon_locations.extend(dungeon_locations)
Expand Down