Setting to include dungeons in spawn entrance pool #1287
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, dungeon entrances were left out of the entrance pool for spawn positions not because it would cause bugs but for balance reasons (spawning inside a dungeon or directly outside of it can bypass item requirements).
This PR converts the “Randomize Overworld Spawns” checkbox into a dropdown setting, where the existing options are called “Off” and “Balanced”, and a new “Full” option is added which includes dungeon entrances.
The presets which previously had the setting enabled are S4 Tournament and Hell Mode. S4 Tournament stays on Balanced while Hell Mode gets upgraded to Full.