Misc hints hint area restrictions #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Feb 22, 2021
As per @Roman971's comment, this has been moved to OoTRandomizer#1248. This reverts commit e1f448c.
|
Hm, looks like GitHub detected this PR as merged somehow but the code isn't actually in Dev. Will resubmit. |
|
Weird. But I don't see any commits in this PR past what I merged for #1212... maybe that's cause you deleted the branch after GitHub thought it was merged, or the commits never got pushed here. |
|
I think what happened is that instead of PRing this as a revert of the revert, I sent the original commit, and since that's a parent of the commit merged in #1212 GitHub detected it as merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the “same hint area” requirements for the potion shop and Impa's house when all hints are off.
Requires #1212 to be merged.