Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in dict_to_thing #80

Closed
koenedaele opened this issue Feb 12, 2020 · 0 comments
Closed

Error in dict_to_thing #80

koenedaele opened this issue Feb 12, 2020 · 0 comments
Assignees
@koenedaele
Labels
backend bug
Milestone
Sprint 124

Comments

@koenedaele
Copy link
Member

In skosprovider_atramhasis.utils.dict_to_thing we apply the dict_to_thing function to all related concepts and collections, turning them into Concept or Collection objets, while they should actually be simple id's. This breaks the API.
@koenedaele koenedaele self-assigned this Feb 12, 2020
@koenedaele koenedaele added this to the Sprint 123 milestone Feb 13, 2020
koenedaele added a commit that referenced this issue Feb 13, 2020
@koenedaele
Ref #80 update docs
486bfca
koenedaele added a commit that referenced this issue Feb 16, 2020
@koenedaele
Update changelog. Refs #80.
5a3a43f
koenedaele added a commit that referenced this issue Feb 16, 2020
@koenedaele
Fix dict_to_thing (#81)
7499554 
Fixed an error in dict_to_thing that caused this provider not to follow
the skosprovider interface. Refs #80
@claeyswo claeyswo modified the milestones: Sprint 123, Sprint 124 Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koenedaele koenedaele

Labels
backend bug
Projects
None yet
Milestone
Sprint 124
Development

No branches or pull requests
2 participants
@koenedaele @claeyswo