Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needed a function to 'clear' an instance of an Aligner #122

Closed
dieuska opened this issue Nov 6, 2024 · 3 comments
Closed

needed a function to 'clear' an instance of an Aligner #122

dieuska opened this issue Nov 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@dieuska
Copy link
Collaborator

dieuska commented Nov 6, 2024

Instead of making a new instance, should it be possible to clear all information of an Aligner-instance, so it can be reused in code.

f.e. Creating an instance of the Aligner on initilaisation of the processe and loading/removing data (thematic/reference) to the same instance.
Or always creating a new instance?

@dieuska dieuska added enhancement New feature or request question Further information is requested labels Nov 6, 2024
@dieuska dieuska self-assigned this Nov 6, 2024
@dieuska
Copy link
Collaborator Author

dieuska commented Nov 6, 2024

probably the reason was found why reusing the Aligner and loading new thematic_data was not working. When loading new thematic_data the thematic union was not reset to None, and the former thematic_union was used. This is fixed as a bug

@dieuska dieuska added the bug Something isn't working label Nov 6, 2024
@dieuska dieuska added this to the 0.5.0 milestone Nov 6, 2024
@dieuska
Copy link
Collaborator Author

dieuska commented Nov 6, 2024

To check if this is fixed

@dieuska dieuska removed the question Further information is requested label Nov 6, 2024
@dieuska
Copy link
Collaborator Author

dieuska commented Nov 7, 2024

checked that this is fixed with #122 commit

@dieuska dieuska closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant