Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky tests #947

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: flaky tests #947

merged 1 commit into from
Jun 1, 2023

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented May 31, 2023

Fixes #

Proposed Changes

@what-the-diff
Copy link

what-the-diff bot commented May 31, 2023

PR Summary

  • Improved Test Stability
    Added a timeout to the first test for better handling of slow editor load

  • Fixed Flaky Tests
    Prevented multiple simultaneous calls to apiGetAskerSessionList for more reliable test results

  • Optimized NavigationBar Rendering
    Stopped unnecessary re-rendering when dispatch changes and added missing effect for hasTools

  • Code Refactoring and Cleanup
    Removed unused code, lint errors, and unnecessary comments in useAskerHasAssignedConsultant hook

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-mi web-mi merged commit 9d7f34a into develop Jun 1, 2023
@web-mi web-mi deleted the OB-Opt branch June 1, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants