Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registration direct links, postcode, concurrent agencies requests #941

Merged
merged 1 commit into from
May 30, 2023

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented May 27, 2023

Fixes #

Proposed Changes

@what-the-diff
Copy link

what-the-diff bot commented May 27, 2023

PR Summary

  • Enhanced API agency selection
    Added signal to apiAgencySelection for better communication with the server.

  • Simplification of URL parameters handling
    Introduced UrlParamsProvider in the app and login component for easier management of URL parameters.

  • Improvements to ConsultingTypeAgencySelection component
    Refactored props and hooks, removed unnecessary preselectedTopic prop, and updated the component to get values from the context or state.

  • Agency selection title logic optimization
    Modified the logic for agency selection title based on consulting types length, and removed the unnecessary mainTopicId prop from FormAccordion.

  • Code cleanup and refactoring
    Removed unused hooks and code, while updating components and making type definitions more specific for better clarity and prevention of bugs.

  • Updates to ProposedAgencies component
    Added a new prop and changed the agency selection method when only one agency is available.

  • Improved translation handling
    Changed translation namespace used by ProposedAgenciesTitle component for better localization.

  • New useConsultantAgenciesAndConsultingTypes hook
    Added this hook for more convenient management of agencies and consulting types.

  • Optimized RocketChatGlobalSettingsProvider
    Fixed an issue with comparing bytes with megabytes, ensuring correct validation of attachment sizes.

@web-mi web-mi marked this pull request as ready for review May 27, 2023 13:23
chore: added testcase example todos for future test improvements
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-mi web-mi merged commit d9a36d0 into develop May 30, 2023
@web-mi web-mi deleted the OB-RegistrationFix branch May 30, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants