Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix flaky testUnattributedSession_afterAllNotificationsPastAttributionWindow #1102

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[Tests] Fix flaky testUnattributedSession_afterAllNotificationsPastAttributionWindow #1102

merged 1 commit into from
Jun 2, 2022

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jun 2, 2022 •
edited by jwilm
Loading

Description

One Line Summary

Fixes flaky testUnattributedSession_afterAllNotificationsPastAttributionWindow test, failing about half the time.

Details

Motivation

Tests should reliability pass.

Scope

Only affects the testUnattributedSession_afterAllNotificationsPastAttributionWindow test.

Testing

Unit testing

testUnattributedSession_afterAllNotificationsPastAttributionWindow was fixed. Used the Xcode "Run "X" Repeatedly" to ensure it is now stable.
image

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Tests

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@jkasten2
Fix flaky testUnattributedSession_afterAllNotificationsPastAttributio…
ed9541d 
…nWindow test

This test failed about half the time due to not waiting for some
background threads. Ensured this test now passes with the Xcode run
repeatly with 100 times.
@jkasten2 jkasten2 force-pushed the tests/fix_flaky_outcome_integration_test branch from 85dd73b to ed9541d Compare June 2, 2022 00:36
@jkasten2 jkasten2 requested review from emawby and nan-li June 2, 2022 00:37
@jkasten2 jkasten2 merged commit c9d37e4 into main Jun 2, 2022
@jkasten2 jkasten2 deleted the tests/fix_flaky_outcome_integration_test branch June 2, 2022 17:44
@emawby emawby mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emawby emawby emawby approved these changes

@nan-li nan-li Awaiting requested review from nan-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @emawby