Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.5 - Deprecation Notice #332

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

2.4.5 - Deprecation Notice #332

wants to merge 4 commits into from

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Nov 8, 2024

One line summary

Add a deprecation notice for OS configuration in the plugin.

Description

This update introduces a deprecation notice displayed at an admin level across the plugin as well as in the plugin dashboard, informing users that OneSignal configuration will be moved to OneSignal.com. The notice links to more detailed documentation.

Additional details:

  • Dismissal Logic: If dismissed, the notice will reappear after 7 days.
  • End Date: Notices will stop reappearing after December 31, 2024, providing a buffer period for users. Although the plugin dashboard notice will always show on the v2 plugin dashboard.

Screenshots:

Admin Panel (Home)

Screenshot 2024-11-08 at 4 19 08 PM

Plugin Dashboard

Screenshot 2024-11-15 at 4 05 59 PM


This change is Reviewable


@rgomezp rgomezp changed the title 2.4.5 2.4.5 - Deprecation Notice Nov 8, 2024
deprecation-notice.php Outdated Show resolved Hide resolved
deprecation-notice.php Outdated Show resolved Hide resolved
marclucraft

This comment was marked as outdated.

@marclucraft
Copy link
Contributor

marclucraft commented Nov 12, 2024

I've knocked up an export feature that we could include - can share this if you want.

Also need to include disable of Auto Update.

Motivation: shows a universal admin-level notice (not just in OS dashboard page) that we are deprecating OS config in this plugin and are moving it to OneSignal.com

If dismissed, we will re-show the notice after 7 days. We will continue re-showing the notice until December 31st 2024 to give a bit of a buffer.
@marclucraft
Copy link
Contributor

@rgomezp – also removed "Setup" tab – it's outdated (and redundant).

@rgomezp
Copy link
Contributor Author

rgomezp commented Nov 15, 2024

@marclucraft Nice thanks for your help on these!

@rgomezp
Copy link
Contributor Author

rgomezp commented Nov 15, 2024

Your changes look good from my end, but just note we won't be building anything to consume the exported file. It would have to be something they figure out or go to support for assistance with -- so keep that mind when considering its inclusion in these changes.

views/config.php Outdated Show resolved Hide resolved
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change in a patch version. Things should keep working as-is for 2.x versions, so we should allow both viewing and editing of these settings.

  • If the customer follows the migration guide, then settings on dashboard.onesignal.com will override these, so optionally we put a warning about that here.

Update tweaked deprecation message
Update tested to 6.7
Clarify that plugin dashboard settings will be overrided after the migration
@marclucraft
Copy link
Contributor

Your changes look good from my end, but just note we won't be building anything to consume the exported file. It would have to be something they figure out or go to support for assistance with -- so keep that mind when considering its inclusion in these changes.

Having export allows users to save any current settings, which is particularly useful with your decision to remove the settings from displaying in this update.

There's no need to consume the exported file. It will contain any customizations that have been made to text and/or colors, which can be manually copied in dashboard from the file as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants