-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.5 - Deprecation Notice #332
base: main
Are you sure you want to change the base?
Conversation
I've knocked up an export feature that we could include - can share this if you want. Also need to include disable of Auto Update. |
Motivation: shows a universal admin-level notice (not just in OS dashboard page) that we are deprecating OS config in this plugin and are moving it to OneSignal.com If dismissed, we will re-show the notice after 7 days. We will continue re-showing the notice until December 31st 2024 to give a bit of a buffer.
c84d66a
to
bca87ca
Compare
@rgomezp – also removed "Setup" tab – it's outdated (and redundant). |
@marclucraft Nice thanks for your help on these! |
Your changes look good from my end, but just note we won't be building anything to consume the exported file. It would have to be something they figure out or go to support for assistance with -- so keep that mind when considering its inclusion in these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change in a patch version. Things should keep working as-is for 2.x versions, so we should allow both viewing and editing of these settings.
- If the customer follows the migration guide, then settings on dashboard.onesignal.com will override these, so optionally we put a warning about that here.
Update tweaked deprecation message Update tested to 6.7
Clarify that plugin dashboard settings will be overrided after the migration
Having export allows users to save any current settings, which is particularly useful with your decision to remove the settings from displaying in this update. There's no need to consume the exported file. It will contain any customizations that have been made to text and/or colors, which can be manually copied in dashboard from the file as necessary. |
One line summary
Add a deprecation notice for OS configuration in the plugin.
Description
This update introduces a deprecation notice displayed at an admin level across the plugin as well as in the plugin dashboard, informing users that OneSignal configuration will be moved to OneSignal.com. The notice links to more detailed documentation.
Additional details:
Screenshots:
Admin Panel (Home)
Plugin Dashboard
This change is