Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set compileSdkVersion 34 to fix build errors #935

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Aug 19, 2024

Description

One Line Summary

Fix lStar not found error due to compileSdkVersion being to old.

Details

Motivation

SDK should compatible with Fluter 3.24.0 and newer.

Scope

Only effect Android compile settings

Related

Fixes issue #930

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Newer versions of Flutter require newer compileSdkVersion
@jkasten2 jkasten2 merged commit 7e921f0 into main Aug 19, 2024
2 checks passed
@jkasten2 jkasten2 deleted the android_compile_version_34 branch August 19, 2024 21:00
@DmitryGaimaldinov
Copy link

If this pull request has been merged could you please release a new version of the package with this hotfix?

@nan-li nan-li mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants