Fix Incorrect Context #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• The OneSignalPlugin was initializing the native OneSignal SDK with an incorrect context. Switched to using the flutter registrar's activeContext instead. • This would have caused the SDK to always believe that the app was not currently in focus, meaning the SDK would ignore the current inFocusDisplayType option and always show notifications as normal Android notifications
jkasten2
approved these changes
Aug 15, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• The OneSignalPlugin was initializing the native OneSignal SDK with an incorrect context. Switched to using the flutter registrar's activeContext instead.
• This would have caused the SDK to always believe that the app was not currently in focus, meaning the SDK would ignore the current inFocusDisplayType option and always show notifications as normal Android notifications
• Fixes issue #7