-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User model] update public api for new event names #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emawby
force-pushed
the
user_model/update_events
branch
from
June 8, 2023 20:45
849db22
to
79225e8
Compare
The OneSignal class now has static fields for all OneSignal functionality. Under the hood it is still using the default instance. The static fields forward the calls onto the singleton instance.
emawby
force-pushed
the
user_model/update_events
branch
from
June 20, 2023 15:57
4bbc5ca
to
b0977d2
Compare
jkasten2
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This PR makes changes to the public api to reflect naming changes for event listeners.
Details
addClickListener
andaddForegroundLifecycleListener
from the native code. The WillDisplay and Click event handlers now fire with new arguments. The WillDisplayEvent args allow you to prevent default display of the notification by callingpreventDefault()
and then usenotification.display()
to display the notification after having prevented default.PushSubscriptionObserver
. The changed event now provides theprevious
andcurrent
push subscription states.PermissionNative()
to get the exact permission type for iOS devicesDefault
shared instance from public api. Instead all fields can be accessed statically on the OneSignal class.This PR also makes some fixes to the project to get the sample app to run as well as a bash script for copying over binaries for native repos.
The migration guide has been updated in this PR to reflect the changes made.
Motivation
naming updates
Scope
Public APIs
Testing
Unit testing
N/A
Manual testing
tested on Android emulator and physical iOS device. All callbacks were tested including preventingDefault/Display
Affected code checklist
Checklist
Overview
Testing
Final pass