Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] IAM with dynamic trigger showing forever #2137

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Commits on Jul 18, 2024

  1. Add a repeat check for trigger combination evaluated to true

    Summary of changes:
      1. When a time-based trigger is evaluated and 'onTriggerCompleted()' is called, we no longer make redisplay messages available to avoid duplicate redisplay of a same message.
      2. Modify the logic of 'makeRedisplayMessagesAvailableWithTriggers()' so that a message can be redisplayed only if at least one trigger has changed or a new trigger is added.
      3. 'onTriggerConditionChanged()' now accepts a new parameter 'triggerId' that indicates the time-based trigger that fires.
    jinliu9508 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7582adf View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Allow redisplay if either an expected trigger has changed or a trigge…

    …r is added when there is only dynamic trigger
    jinliu9508 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ea912ff View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    26a1dfd View commit details
    Browse the repository at this point in the history