Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] RecoverFromDroppedLoginBug not running in very rare cases #2084

Commits on May 9, 2024

  1. proving onOperationRepoLoaded doesn't always fire

    Add test to prove onOperationRepoLoaded doesn't always fire.
    Refactored test to make it easier to share mocks between tests.
    jkasten2 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b04a96a View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. swap EventProducer for CompletableDeferred

    This change fixes a rare bug where RecoverFromDroppedLoginBug may not
    run. While very rare this could happen if start was called on
    OperationRepo first and it finished before
    RecoverFromDroppedLoginBug.start was called.
    
    We swapped out EventProducer for a CompletableDeferred to address this
    issue. CompletableDeferred is a better fit as we simply need to wait
    until something is initialized, and it will never fire more than once.
    
    We also refactored RecoverFromDroppedLoginBugTests to account for the
    change, but improved the testing to ensure the operation itself is
    correct.
    jkasten2 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d6d0f52 View commit details
    Browse the repository at this point in the history