Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix flaky tests 2024/05/09 #2083

Merged
merged 3 commits into from
May 10, 2024
Merged

[Tests] Fix flaky tests 2024/05/09 #2083

merged 3 commits into from
May 10, 2024

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented May 9, 2024 •
edited
Loading

Description

One Line Summary

Fix some flaky test related to the OperationRepo and HttpClient.

Details

Motivation

We want tests to be stable and reliable.

Scope

Only corrects tests.

Testing

Unit testing

Fixed three tests, recommend reviewing commit by commit.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jkasten2
wait for operation repo to start completely
346b4ce 
Ran 100 times to ensure this test is now stable.
@jkasten2
flaky test due to not waiting for OperationRepo
685e471 
This test had two problems:
1. We were not waiting for OperationRepo.loadSavedOperations to finish
2. After we added waiting, it didn't work we didn't wrap
RecoverFromDroppedLoginBug in spyk(). This was causing all fields
and properties being cleared from it!
@jkasten2
fix flaky Retry-After test
939a164 
Test sometimes failed on "response2 shouldBe null"
@jkasten2 jkasten2 merged commit 21eb136 into main May 10, 2024
2 checks passed
@jkasten2 jkasten2 deleted the tests/fix-flaky-tests-2024-05-09 branch May 10, 2024 20:37
@jkasten2 jkasten2 mentioned this pull request May 10, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinliu9508 jinliu9508 jinliu9508 approved these changes

@iAmWillShepherd iAmWillShepherd Awaiting requested review from iAmWillShepherd

@nan-li nan-li Awaiting requested review from nan-li

@emawby emawby Awaiting requested review from emawby

@jennantilla jennantilla Awaiting requested review from jennantilla

Assignees

@jinliu9508 jinliu9508

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @jinliu9508