Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): fix the display issue in conflux transactions where data… #575

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

somebodyLi
Copy link
Contributor

… is nonempty and transfer value is nonzero

Copy link

what-the-diff bot commented Aug 5, 2024

PR Summary

  • Introduction of a New Parameter: data and data_len
    The function layoutConfluxConfirmTx in conflux.c file now accepts two extra arguments, titled data and data_len. The update serves to enhance the function's efficiency and flexibility.

  • Enhancements in layoutConfluxConfirmTx
    This function has been updated to incorporate and process the newly introduced data parameter, thereby improving its functionality.

  • Addition of Parameters to layoutTransactionSign Function
    In the conflux.c file, the function layoutTransactionSign now includes const uint8_t *data, uint32_t data_len as additional parameters, enhancing its comprehensiveness toward data handling.

  • Modifications in layoutTransactionSign
    To incorporate the new data variable, the layoutTransactionSign function has been updated, making it more adaptable to different data inputs.

  • Updates in conflux_signing_init Function
    The function conflux_signing_init has been adjusted to relay NULL, 0 values for data to the layoutConfluxConfirmTx function, ensuring consistent communication between different function calls.

loatheb
loatheb previously approved these changes Aug 5, 2024
@loatheb loatheb merged commit f3b0717 into OneKeyHQ:bixin_dev Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants