Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

New software recovery process (supports btc batch requests) #903

Draft
wants to merge 1 commit into
base: bixin_dev
Choose a base branch
from

Conversation

shuaiLiWang
Copy link

What does this implement/fix? Explain your changes.

新的恢复账户流程(软件部分实现)

Does this close any currently open issues?

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Pull request type

Put an x in the boxes that apply

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Where has this been tested?

Any other comments?

@shuaiLiWang shuaiLiWang marked this pull request as draft September 7, 2021 07:04
electrum_gui/common/wallet/manager.py Outdated Show resolved Hide resolved
electrum_gui/android/console.py Show resolved Hide resolved
electrum_gui/common/wallet/manager.py Outdated Show resolved Hide resolved
electrum_gui/common/wallet/manager.py Outdated Show resolved Hide resolved
electrum_gui/common/wallet/manager.py Show resolved Hide resolved
@shuaiLiWang shuaiLiWang force-pushed the new_recovery_accounts branch from bddb673 to 40cd797 Compare September 8, 2021 10:01
electrum_gui/common/wallet/manager.py Outdated Show resolved Hide resolved
electrum_gui/common/wallet/manager.py Outdated Show resolved Hide resolved
@shuaiLiWang shuaiLiWang force-pushed the new_recovery_accounts branch from 40cd797 to e85c5b6 Compare September 8, 2021 14:51
@shuaiLiWang
Copy link
Author

@huazhouwang 看下 都测试过了

@huazhouwang
Copy link

huazhouwang commented Sep 9, 2021

嗯,我看到了,建议你先自己测试下 search_existing_wallets 方法并写下测试用例。
我觉得该接口目前的返回值是有问题的,你应该提供所有搜索到的路径方便后续的恢复流程

@shuaiLiWang
Copy link
Author

你应该提供所有搜索到的路径方便后续的恢复流

我测试过了啊 返回结果是包含了查询到的有交易记录的path的 测试用例我一会儿补上 (不好意思 这条信息我昨天以为我回复了 今天一看 额。。。没发出去)

@shuaiLiWang shuaiLiWang force-pushed the new_recovery_accounts branch 2 times, most recently from fa4413b to 72da60c Compare September 10, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants