This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
forked from haobtc/electrum
-
Notifications
You must be signed in to change notification settings - Fork 15
New software recovery process (supports btc batch requests) #903
Draft
shuaiLiWang
wants to merge
1
commit into
OneKeyHQ:bixin_dev
Choose a base branch
from
shuaiLiWang:new_recovery_accounts
base: bixin_dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huazhouwang
reviewed
Sep 7, 2021
shuaiLiWang
force-pushed
the
new_recovery_accounts
branch
from
September 8, 2021 10:01
bddb673
to
40cd797
Compare
huazhouwang
reviewed
Sep 8, 2021
shuaiLiWang
force-pushed
the
new_recovery_accounts
branch
from
September 8, 2021 14:51
40cd797
to
e85c5b6
Compare
@huazhouwang 看下 都测试过了 |
嗯,我看到了,建议你先自己测试下 search_existing_wallets 方法并写下测试用例。 |
我测试过了啊 返回结果是包含了查询到的有交易记录的path的 测试用例我一会儿补上 (不好意思 这条信息我昨天以为我回复了 今天一看 额。。。没发出去) |
huazhouwang
reviewed
Sep 10, 2021
shuaiLiWang
force-pushed
the
new_recovery_accounts
branch
2 times, most recently
from
September 10, 2021 15:23
fa4413b
to
72da60c
Compare
shuaiLiWang
force-pushed
the
new_recovery_accounts
branch
from
September 10, 2021 15:24
72da60c
to
c475ffa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
新的恢复账户流程(软件部分实现)
Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Pull request type
Put an
x
in the boxes that applyWhere has this been tested?
…
Any other comments?
…