Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to the firmware header. && bump version to 2.3.3 #52

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

lihuanhuan
Copy link
Contributor

@lihuanhuan lihuanhuan commented Dec 6, 2024

Summary by CodeRabbit

  • 新特性

    • 固件版本号已更新至“2.3.3”,反映了固件功能或特性的潜在增强。
    • 引入了版本偏移量常量,增强了生成二进制文件时的版本信息处理。
  • 改进

    • 更新了生成二进制文件的功能,以从固件配置头文件中读取并解析版本信息。

Copy link

coderabbitai bot commented Dec 6, 2024

Walkthrough

此次更改涉及两个文件。firmware_config.h 文件的固件版本号从 "2.3.2" 更新为 "2.3.3"。在 utils/ota_to_onekey_bin.py 文件中,新增了用于存储版本信息的常量,并更新了 gen_onekey_bin 函数,以从头文件中读取和解析固件版本。这些更改确保了生成的二进制文件中正确集成了版本数据。

Changes

文件路径 更改摘要
app/firmware_config.h 更新宏 FW_REVISION 从 "2.3.2" 到 "2.3.3"。
utils/ota_to_onekey_bin.py 添加常量 OFFSET_VERSION_MAJOROFFSET_VERSION_MINOROFFSET_VERSION_PATCH;更新 gen_onekey_bin 函数以读取和解析固件版本。

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 338c2a0 and f203ac8.

📒 Files selected for processing (2)
  • app/firmware_config.h (1 hunks)
  • utils/ota_to_onekey_bin.py (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/firmware_config.h

@lihuanhuan lihuanhuan enabled auto-merge (squash) December 6, 2024 06:33
@lihuanhuan lihuanhuan merged commit 82f4ec8 into OneKeyHQ:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants