Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ahk): support for capslock key #93

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

Geobert
Copy link
Collaborator

@Geobert Geobert commented Feb 7, 2024

It works when an obvious upper case is found, so it will not work for the num row and other symbols

It works when an obvious upper case is found, so it will not work for the num row  and other symbols
@fabi1cazenave
Copy link
Collaborator

That’s exactly what we need, at least in the short term since that’s what Kalamine does behind the scenes anyway : there’s no way currently to specify manually how CapsLock is supposed to work on each supported character.

Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help !

So we can factorise the GetKeyState
Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the character length would be wise. Otherwise thanks for this good work, your help is very appreciated!

Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good ! I think you forgot a leftover so I’ve nitpicked again.

Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks a lot. :-)

@fabi1cazenave fabi1cazenave merged commit 21f2f30 into OneDeadKey:main Feb 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants