-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ahk): support for capslock key #93
Conversation
It works when an obvious upper case is found, so it will not work for the num row and other symbols
That’s exactly what we need, at least in the short term since that’s what Kalamine does behind the scenes anyway : there’s no way currently to specify manually how CapsLock is supposed to work on each supported character. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help !
So we can factorise the GetKeyState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing the character length would be wise. Otherwise thanks for this good work, your help is very appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good ! I think you forgot a leftover so I’ve nitpicked again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks a lot. :-)
It works when an obvious upper case is found, so it will not work for the num row and other symbols