Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yili - Fix the issue for non-Owner/Admin accounts that have the 'Edit Team 4-Digit Codes' permission, allowing them to edit the team code #2933

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

suaniii
Copy link
Contributor

@suaniii suaniii commented Dec 8, 2024

Description

Fix the issue for non-Owner:Admin accounts that have the 'Edit Team 4-Digit Codes' permission, allowing them to edit the team code

Related PRS (if any):

This frontend PR is related to the backend PR #1172

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to Other Links -> Permissions Management -> Manage User Permissions -> Choose a volunteer user -> Permissions -> Reports -> Edit Team 4-Digit Codes -> Click on "Add" -> Click on "save changes"
  6. log as the volunteer user with permission
  7. go to another volunteer's profile
  8. verify that the user who was given the permission is now able to edit edit team codes on other users' profiles

Screenshots or videos of changes:

pr.mov
1 2

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit b79396d
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/6755037fc32a1d00089ea753
😎 Deploy Preview https://deploy-preview-2933--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.113.mp4

@ShraddhaShahari ShraddhaShahari self-requested a review December 14, 2024 01:04
Copy link
Contributor

@ShraddhaShahari ShraddhaShahari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything working as expected.
Please find below screenshots for the reference.

Screenshot 2024-12-13 at 5 03 46 PM Screenshot 2024-12-13 at 5 02 01 PM

@one-community one-community added High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible and removed medium priority labels Jan 1, 2025
@kobakvantrishvili
Copy link
Contributor

Left a review on the backend PR #1172

Copy link
Contributor

@honglinchen0524 honglinchen0524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All features work as expected. Great work!

PR2933.mp4

Copy link

@yany960 yany960 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all features in this PR, everything working as expected.
WeChatba84021406e651a58a03ec33c72846ad
WeChat71287b690fb5bc319b427601946b5eee

Copy link

@k1guo k1guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2933 I review the code. everything works as expect. Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants