Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mohan - hotfix Visibility toggle Alignment In Teams #2908

Conversation

mohangadde1
Copy link
Contributor

@mohangadde1 mohangadde1 commented Nov 30, 2024

Description

PR will Fix the Visibility toggle Alignment In Teams

Related PRS (if any):

No Related PR

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ View Profile→ Teams
  6. verify function in both dark and light mode

Screenshots or videos of changes:

Before

image

After

image

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ca6837e
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/67527e26a9d2360008002cb9
😎 Deploy Preview https://deploy-preview-2908--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and everything works as expected.

PR.vid.99.mp4

jinxyou
jinxyou previously approved these changes Nov 30, 2024
Copy link
Contributor

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and it works in both mode.
Screenshot 2024-11-30 004134
Screenshot 2024-11-30 004148

Copy link
Member

@one-community one-community left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix is so these are aligned with the ones below too:
image

Copy link

@RashmiKY98 RashmiKY98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing the size of the screen, the visibility toggle appears below Visibility header. Request you to look into the issue.
image

Copy link

@NazaninHashemian NazaninHashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changes in this PR, which addresses the visibility toggle alignment in the Teams section. The functionality works as expected, and I verified it in both dark and light modes. The UI changes seem to be functioning correctly.

However, during my testing, I encountered an issue with the developer account not being able to log in locally. I was able to log in successfully on the live version of the site, so this issue seems to be related to my local environment or backend configuration rather than the changes in this PR.

Since the PR does not affect authentication or backend functionality, I believe it is ready to be merged. Please note that the login issue appears to be a separate concern that I will address locally.
3
4
5
6
notworkingDeveloperAccount

@pallavithorat
Copy link
Contributor

I have tested the PR by verifying the functionality of the 'Teams' section under both dark and light modes. Everything works as expected.
Screenshot 2024-12-03 at 2 51 06 PM
Screenshot 2024-12-03 at 2 51 28 PM

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit cd5acee into development Dec 6, 2024
5 checks passed
Copy link

@SammanBaidya SammanBaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the changes which works as intended. Works in both light and dark mode.

PR4 1 #2908
PR4 2 #2908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants