-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify OTPKit repo to Swift Package #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! Before this gets merged, though, the tests need to be restored and the CI needs to be fixed. let me know if you need help with either
Understood! About the test, should I restore the test for the demo app or the package? |
Package if that's possible |
Hi @aaronbrethorst, I already add the test and fix the CI. For CI, I only add the test build for testing purposes because Swift Package only able to build the test scheme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Make the whole repo as Swift Package
Related Issues
Fixes #45
Test Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce.
Additional Context