Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Itinerary View #39

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Modify Itinerary View #39

merged 3 commits into from
Aug 5, 2024

Conversation

hilmyveradin
Copy link
Collaborator

@hilmyveradin hilmyveradin commented Aug 4, 2024

Description

Enhance Itinerary Trip Planner View so that it becomes similar to Maps

Related Issues

Fixes #17
Fixes #38

Media

image

Test Instructions

  1. Search for a place with it's trip planner
  2. See if the view is changed or not

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! I have a couple questions that I'd love to clear up before merging, but I love what you did here :)

OTPKit/Features/TripPlanner/TripPlannerSheetView.swift Outdated Show resolved Hide resolved
OTPKit/Features/TripPlanner/TripPlannerSheetView.swift Outdated Show resolved Hide resolved
@aaronbrethorst
Copy link
Member

@hilmyveradin looking good! I pushed up some changes so you can see what I mean about DRY'ing up those leg views. Please let me know if you have any questions.

@aaronbrethorst aaronbrethorst merged commit 570b3af into main Aug 5, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the modify-trip-planner-view branch August 5, 2024 21:32
@hilmyveradin
Copy link
Collaborator Author

Ah understood. I don't have any questions right now. Thank you for improving my previous mistakes ^^

@hilmyveradin looking good! I pushed up some changes so you can see what I mean about DRY'ing up those leg views. Please let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Intinerary Preview List Available Itineraries From a Plan result
2 participants