-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Migration concurrency overhaul #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wow this worked on the first try
Make DataMigrator a class (UserDefaults is non-sendable)
Fixes #625 - Update NSKeyedUnarchiver usage in MigrationDataExtractor
Move header view to separate file
@ualch9 this looks awesome, great work! I'll give it a proper review tomorrow. |
aaronbrethorst
requested changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I noticed a couple strings that look like they need to be wrapped in OBALoc
but otherwise I think it's good to go.
@ualch9 looks good! I think this can be merged if you're ready to do so. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #622...
debugMode
is on,Migrate Data
in settings will always appear.OBAKitCore.UnstructuredError
for arbitrary string errors.nil
orprint()
and allows us to do better customer support (i.e. from a user screenshot).DataMigrationBulletin
withDataMigrationView
, andDataMigrationReportView
. It is currently not hooked up to the onboarding sequence.Screen.Recording.2023-01-06.at.1.14.41.PM.mov