Speculative fix for “DUPLICATE_ITEM_IDENTIFIERS” and “EQUAL_IDENTIFIERS_HAVE_DIFFERENT_HASH_VALUES” crasher #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RS_HAVE_DIFFERENT_HASH_VALUES” crasher Changes view models to always generate a new identifier per instance. This is a speculative fix and intended as a stop gap (causes entire table view to update) before fixing OBAListView’s flawed implementation.
| @@ -33,7 +33,7 @@ extension AgencyAlertListViewConverters where Self: UIViewController { | |||
| return TransitAlertDataListViewModel(alert, isUnread: isUnread, forLocale: Locale.current, onSelectAction: presentAlertAction) | |||
| } | |||
|
|
|||
| let alerts = viewModels.uniqued.sorted(by: \.title) // remove duplicates | |||
| let alerts = viewModels.sorted(by: \.title) // remove duplicates | |||
|
looks like a good step forward. nice work 👍 |
|
ah-- unit tests succeeded, but CI failing on the "Update xcresult bundle" step. Looks like forks can't access CI results here, for security. I'll move work onto this repo instead, but we should find a way to mark that step as optional for other contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View models now has a guaranteed unique identifier (by UUID during initialization). This is fine for now, since we are directly consuming API results, but at the cost of potentially causing the entire table view to update when one item changes.
Ultimately,
OBAListViewimplementation is flawed and requires a bit of fixing, so this is a stop gap.