Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to full sheet on voiceover #575

Merged
merged 6 commits into from
Nov 30, 2021

Conversation

ualch9
Copy link
Member

@ualch9 ualch9 commented Nov 22, 2021

  • Add preferredLoadDataRegionFudgeFactor to MapRegionManager
  • Add alert informing voiceover users of the change
  • Defaults floatingPanel ("sheet") to full position in MapViewController and TripViewController.

I'm using "sheet" because of UISheetPresentationController.

Fixes #431
Fixes #572

@ualch9 ualch9 changed the title Default to expanded sheet on voiceover Default to full sheet on voiceover Nov 22, 2021
@aaronbrethorst aaronbrethorst self-assigned this Nov 30, 2021
@aaronbrethorst aaronbrethorst self-requested a review November 30, 2021 02:01
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work 👍

@aaronbrethorst aaronbrethorst merged commit 1d8cba1 into OneBusAway:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants