Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dark Sky references #650

Closed
devinbraun opened this issue Feb 27, 2023 · 4 comments · Fixed by #651
Closed

Remove Dark Sky references #650

devinbraun opened this issue Feb 27, 2023 · 4 comments · Fixed by #651
Assignees
@aaronbrethorst
Labels
Weather
Milestone
23.2

Comments

@devinbraun
Copy link

When clicking in the app for information about the DarkSky weather service, the Dark Sky API states that support will end on 3/31/23. This is not an in-app message, but a message on the DarkSky Docs website.
@ualch9
Copy link
Member

ualch9 commented Feb 28, 2023 •
edited
Loading

Duplicate of #223, which is currently scheduled for version 23.3.

@ualch9 ualch9 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@aaronbrethorst
Copy link
Member

I've actually replaced Dark Sky on the backend. OneBusAway/onebusaway-deep-links@79cbc3a

This message should be removed from the OBA app as it's no longer relevant.

@ualch9
Copy link
Member

ualch9 commented Feb 28, 2023

Oh neat. I think then we should remove Dark Sky references from the app for 23.2, and continue with #223 when I get the chance.

@ualch9 ualch9 reopened this Feb 28, 2023
@ualch9 ualch9 changed the title DarkSky API Support Ends 3/31/23 Remove Dark Sky references Feb 28, 2023
@ualch9 ualch9 added this to the 23.2 milestone Feb 28, 2023
@ualch9 ualch9 added the Weather label Feb 28, 2023
@aaronbrethorst
Copy link
Member

Right on, sounds like a good plan @ualch9

@aaronbrethorst aaronbrethorst self-assigned this Feb 28, 2023
aaronbrethorst added a commit that referenced this issue Feb 28, 2023
@aaronbrethorst
Remove references to Dark Sky from app
d43381c 
Fixes #650
@aaronbrethorst aaronbrethorst mentioned this issue Feb 28, 2023
Merged
aaronbrethorst added a commit that referenced this issue Mar 8, 2023
@aaronbrethorst
Remove references to Dark Sky from app
f634855 
Fixes #650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronbrethorst aaronbrethorst

Labels
Weather
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

Remove references to Dark Sky from app OneBusAway/onebusaway-ios
3 participants
@aaronbrethorst @devinbraun @ualch9