Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Roslyn's analyzer assembly loader #2236

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Reuse Roslyn's analyzer assembly loader #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f18443
Specify we sort system namespaces first in files
jasonmalinowski Sep 17, 2021
85f35cf
Reuse Roslyn's analyzer assembly loader
jasonmalinowski Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ dotnet_diagnostic.VSTHRD105.severity = none
dotnet_diagnostic.VSTHRD110.severity = none
dotnet_diagnostic.VSTHRD200.severity = none

dotnet_sort_system_directives_first = true

[*.cs]
indent_size = 4

Expand Down
4 changes: 2 additions & 2 deletions src/OmniSharp.Host/CompositionHostBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
using OmniSharp.Eventing;
using OmniSharp.FileSystem;
using OmniSharp.FileWatching;
using OmniSharp.Host.Services;
using OmniSharp.Mef;
using OmniSharp.MSBuild.Discovery;
using OmniSharp.Options;
using OmniSharp.Roslyn;
using OmniSharp.Roslyn.Utilities;
using OmniSharp.Services;

namespace OmniSharp
Expand Down Expand Up @@ -137,7 +137,7 @@ public static IServiceProvider CreateDefaultServiceProvider(
// Caching
services.AddSingleton<IMemoryCache, MemoryCache>();
services.AddSingleton<IAssemblyLoader, AssemblyLoader>();
services.AddSingleton<IAnalyzerAssemblyLoader, DefaultAnalyzerAssemblyLoader>();
services.AddSingleton(sp => ShadowCopyAnalyzerAssemblyLoader.Instance);
services.AddOptions();

// Setup the options from configuration
Expand Down
327 changes: 0 additions & 327 deletions src/OmniSharp.Host/Services/AnalyzerAssemblyLoader.cs
View file
Open in desktop

This file was deleted.

Loading