Upgrade lsp #1911
Merged
Upgrade lsp #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added diagnostic related helper methods to the base test class
|
The diagnostic changes were really triggered by working on the LSP Engine in vscode, as I'm working through getting all the integration tests to pass. |
filipw
approved these changes
Aug 25, 2020
|
thanks! |
razzmatazz
added a commit
to razzmatazz/lsp-mode
that referenced
this pull request
Sep 20, 2020
These were added by OmniSharp/omnisharp-roslyn#1911 to facilitate legacy clients (i.e. vscode) that will be transitioning to LSP.
ericdallo
pushed a commit
to emacs-lsp/lsp-mode
that referenced
this pull request
Sep 21, 2020
* lsp-csharp: ignore interop notifications These were added by OmniSharp/omnisharp-roslyn#1911 to facilitate legacy clients (i.e. vscode) that will be transitioning to LSP. * lsp-csharp: add handler for the 'o#/error' notification This improves diagnostic procedure when projects cannot be loaded for some reason. * lsp-csharp: use &omnisharp:ErrorMessage to decompose params As per code review * lsp-csharp: use lsp-defun for lsp-csharp--handle-os-error * lsp-csharp: doc string fix for lsp-csharp--handle-os-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractLanguageServerTestBaseContent Modifiederrors,LSP update Fixes: #1898