Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET Core SDK 3.1.201 #1790

Closed
wants to merge 3 commits into from

Conversation

xtqqczze
Copy link

Support for .NET Core 3.0 ended on 2020-03-03, we should update to 3.1.

@dnfclas
Copy link

dnfclas commented May 11, 2020

CLA assistant check
All CLA requirements met.

@xtqqczze
Copy link
Author

OmniSharp.omnisharp-roslyn (Windows):

2020-05-11T04:44:11.1633121Z read: {"MessageType":"TestSession.Message","Payload":{"MessageLevel":2,"Message":"Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: A fatal error occurred, the required library hostfxr.dll could not be found.\r\nIf this is a self-contained application, that library should exist in [C:\Users\VssAdministrator\.nuget\packages\microsoft.testplatform.testhost\16.3.0\build\netcoreapp2.1\x86\].\r\nIf this is a framework-dependent application, install the runtime in the default location [C:\Program Files (x86)\dotnet] or use the DOTNET_ROOT(x86) environment variable to specify the runtime location.\r\n. Please check the diagnostic logs for more information.\r\n at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowExceptionOnConnectionFailure(Int32 connTimeout)\r\n at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings)\r\n at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)"}}

@filipw
Copy link
Member

filipw commented May 11, 2020

thanks a lot - however there is unfortunately #1782 which was merged today contained the same change already. thanks for your PR.

@filipw filipw closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants