Fix "Ambiguity" errors appearing when files are modified during project load #1357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1356
Context of what happens:
This unfortunate timing means that both "TryPromote" and "ProjectLoad" create each their own version of non-misc document (and ambiguity errors follow).
Moving "TryPromote" after actual project load, lets MSBuild properly delete misc files, so unnecessary document creating in "TryPromote" is avoided
cc @akshita31 @rchande @DustinCampbell
On a sIde note:
Its weird that MiscProject has its own version of "Try-to-put-file-into-exisitng-projects" - IMHO TryPromote should use some part of bufferManager's "TryAddTransientDocument".