in scripting, load inherited assemblies from the current AppDomain #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @filipw -- we'd like to take this fix as part of a 1.15.2 update to C# for VS Code. I'm going to merge this and cherrypick it to a new branch based on 1.30.0. Then, we can produce an OmniSharp release for 1.13.1 from that branch and use it in the C# for VS Code update. Sound good? We're aiming for early next week for that release. cc @rchande and @TheRealPiotrP |
|
great! that would be very much appreciated! 🤩 |
david-driscoll
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Rather than trying to resolve them from
OmniSharp.deps.jsonwithMicrosoft.Extensions.DependencyModel, we just grab them from the current AppDomain. This is much simpler and much more reliable, because we have seen now that it's possible forMicrosoft.Extensions.DependencyModelto throw on non-Windows platforms.This is impossible to test from unit tests. In fact we have a unit test that check the correct behavior of the script host object (which is really the case here) but as mentioned in #1184, the problem only manifested itself in certain situation.