minimum VS2019 is now 16.3

OmniSharp · Feb 15, 2020 · 77c4cd3 · 77c4cd3
1 parent 4ee78e4
commit 77c4cd3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/OmniSharp.Host/MSBuild/Discovery/Extensions.cs b/src/OmniSharp.Host/MSBuild/Discovery/Extensions.cs
@@ -95,7 +95,7 @@ private static int GetInstanceFeatureScore(MSBuildInstance i)
                 score--;
 
             // VS 2019 should be preferred
-            if (i.Version.Major >= 16)
+            if (i.Version.Major >= 16 && i.Version.Minor >= 3)
                 score++;
             else
                 score--;

diff --git a/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs b/src/OmniSharp.Host/MSBuild/Discovery/Providers/MonoInstanceProvider.cs
@@ -112,7 +112,7 @@ public override ImmutableArray<MSBuildInstance> GetInstances()
                 new MSBuildInstance(
                     nameof(DiscoveryType.Mono),
                     toolsPath,
-                    new Version(16, 3),
+                    new Version(16, 4),
                     DiscoveryType.Mono,
                     propertyOverrides.ToImmutable()));
         }

diff --git a/src/OmniSharp.Host/MSBuild/Discovery/Providers/StandAloneInstanceProvider.cs b/src/OmniSharp.Host/MSBuild/Discovery/Providers/StandAloneInstanceProvider.cs
@@ -46,7 +46,7 @@ public override ImmutableArray<MSBuildInstance> GetInstances()
                 new MSBuildInstance(
                     nameof(DiscoveryType.StandAlone),
                     toolsPath,
-                    new Version(16, 3), // we now ship with embedded MsBuild 16.3
+                    new Version(16, 4), // we now ship with embedded MsBuild 16.4
                     DiscoveryType.StandAlone,
                     propertyOverrides.ToImmutable(),
                     setMSBuildExePathVariable: true));