Merge pull request #2032 from OmniSharp/feature/10sec-gotodefinition

raise default GotoDefinitionRequest timeout from 2s to 10s
OmniSharp · Dec 5, 2020 · 044a8c9 · 044a8c9
2 parents 5a64da0 + d8e5c55
commit 044a8c9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/OmniSharp.Abstractions/Models/v1/GotoDefinition/GotoDefinitionRequest.cs b/src/OmniSharp.Abstractions/Models/v1/GotoDefinition/GotoDefinitionRequest.cs
@@ -5,7 +5,7 @@ namespace OmniSharp.Models.GotoDefinition
     [OmniSharpEndpoint(OmniSharpEndpoints.GotoDefinition, typeof(GotoDefinitionRequest), typeof(GotoDefinitionResponse))]
     public class GotoDefinitionRequest : Request
     {
-        public int Timeout { get; set; } = 2000;
+        public int Timeout { get; set; } = 10000;
         public bool WantMetadata { get; set; }
     }
 }
diff --git a/src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs b/src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs
@@ -32,7 +32,7 @@ public IExternalSourceService Create(OmniSharpOptions omniSharpOptions)
         public CancellationToken CreateCancellationToken(OmniSharpOptions omniSharpOptions, int timeout)
         {
             var enableDecompilationSupport = omniSharpOptions.RoslynExtensionsOptions.EnableDecompilationSupport;
-            // since decompilation is slower, use a larger cancellation time (default is 2s per request)
+            // since decompilation is slower, use a larger cancellation time
             var cancellationTimeout = enableDecompilationSupport
                 ? timeout <= 10000 ? 10000 : timeout // minimum 10s for decompilation
                 : timeout; // request defined for metadata