Fix trace state parsing.

[NTaylorMullen]

• Without this the .Value<string> was exploding attempting to convert to a string.

[NTaylorMullen]

/cc @david-driscoll @ToddGrun

[codecov]

Codecov Report

Merging #638 (9bc65b7) into master (5281160) will decrease coverage by 3.52%.
The diff coverage is 75.00%.

❗ Current head 9bc65b7 differs from pull request most recent head 9eec18e. Consider uploading reports for the commit 9eec18e to get more accurate results

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   72.89%   69.37%   -3.53%     
==========================================
  Files         257      257              
  Lines       12576    12580       +4     
  Branches      848      848              
==========================================
- Hits         9167     8727     -440     
- Misses       3409     3583     +174     
- Partials        0      270     +270     

Impacted Files	Coverage Δ
src/JsonRpc/Receiver.cs	90.27% <75.00%> (-6.79%)	⬇️
src/JsonRpc/ExternalServiceProvider.cs	50.00% <0.00%> (-50.00%)	⬇️
src/JsonRpc.Generators/SymbolExtensions.cs	71.42% <0.00%> (-28.58%)	⬇️
src/JsonRpc/Server/ContentModifiedException.cs	37.50% <0.00%> (-18.75%)	⬇️
src/JsonRpc/Server/RequestCancelledException.cs	37.50% <0.00%> (-18.75%)	⬇️
...rver/Configuration/ChainedConfigurationProvider.cs	58.62% <0.00%> (-17.25%)	⬇️
...ient/Configuration/ChainedConfigurationProvider.cs	0.00% <0.00%> (-17.25%)	⬇️
...rver/Configuration/ChainedConfigurationProvider.cs	0.00% <0.00%> (-17.25%)	⬇️
src/JsonRpc/Server/ServerErrorResult.cs	83.33% <0.00%> (-16.67%)	⬇️
src/JsonRpc.Generators/Contexts/SyntaxSymbol.cs	75.00% <0.00%> (-16.67%)	⬇️
... and 97 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5281160...9eec18e. Read the comment docs.

[andyleejordan]

@NTaylorMullen just out of curiosity, can I see how this was failing for you? In case something similar crops up in PowerShell Editor Services 😆

[NTaylorMullen]

@NTaylorMullen just out of curiosity, can I see how this was failing for you? In case something similar crops up in PowerShell Editor Services 😆

I have it all patched locally so not easy to reproduce but it was a Cast exception. The gist is that when you got a jsonrpc payload which had:

{
    "traceparent": "alskdfj-asldkjf-asdj-asdflkj-sadfjasd-fj"
    ....
}

If you have the powershell language server running in VS you'll see the exception too (they provide tracing); although I don't believe VSCode's jsonrpc bits do.

[andyleejordan]

Oh interesting, not sure I was using traceparent yet but I remember seeing it get enabled.

[andyleejordan]

Ah yes this PR: #553

[andyleejordan]

Taylor, do you think your PR will fix #609 too?

[NTaylorMullen]

Taylor, do you think your PR will fix #609 too?

Yup, absolutely will fix that!