-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thread debugging #567
Fix thread debugging #567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 73.40% 69.57% -3.83%
==========================================
Files 256 235 -21
Lines 12246 11809 -437
Branches 827 800 -27
==========================================
- Hits 8989 8216 -773
- Misses 3257 3377 +120
- Partials 0 216 +216
Continue to review full report at Codecov.
|
@@ -2,7 +2,6 @@ | |||
using OmniSharp.Extensions.DebugAdapter.Protocol.Models; | |||
using OmniSharp.Extensions.JsonRpc; | |||
using OmniSharp.Extensions.JsonRpc.Generation; | |||
using Thread = System.Threading.Thread; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG this is all it was?! So this type came in and overrode the Thread in Protocol.Models
...I was a bit confused by this when I brought in the update but didn't know how much of a worry it was PowerShell/PowerShellEditorServices@327061f
Thanks @rjmholt |
Fixes #566