Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread debugging #567

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 19, 2021

Fixes #566

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #567 (24fedfb) into master (1b6788d) will decrease coverage by 3.82%.
The diff coverage is 40.00%.

❗ Current head 24fedfb differs from pull request most recent head 1e2c11b. Consider uploading reports for the commit 1e2c11b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   73.40%   69.57%   -3.83%     
==========================================
  Files         256      235      -21     
  Lines       12246    11809     -437     
  Branches      827      800      -27     
==========================================
- Hits         8989     8216     -773     
- Misses       3257     3377     +120     
- Partials        0      216     +216     
Impacted Files Coverage Δ
...erialization/Converters/EnumLikeStringConverter.cs 62.50% <40.00%> (-20.84%) ⬇️
src/JsonRpc/ExternalServiceProvider.cs 50.00% <0.00%> (-50.00%) ⬇️
src/JsonRpc.Generators/SymbolExtensions.cs 71.42% <0.00%> (-28.58%) ⬇️
src/Dap.Client/ProgressObservable.cs 0.00% <0.00%> (-22.23%) ⬇️
src/JsonRpc/Server/ContentModifiedException.cs 37.50% <0.00%> (-18.75%) ⬇️
src/JsonRpc/Server/RequestCancelledException.cs 37.50% <0.00%> (-18.75%) ⬇️
...rver/Configuration/ChainedConfigurationProvider.cs 58.62% <0.00%> (-17.25%) ⬇️
...ient/Configuration/ChainedConfigurationProvider.cs 0.00% <0.00%> (-17.25%) ⬇️
...rver/Configuration/ChainedConfigurationProvider.cs 0.00% <0.00%> (-17.25%) ⬇️
src/JsonRpc/Server/ServerErrorResult.cs 83.33% <0.00%> (-16.67%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6788d...1e2c11b. Read the comment docs.

@rjmholt rjmholt marked this pull request as ready for review April 19, 2021 21:41
@@ -2,7 +2,6 @@
using OmniSharp.Extensions.DebugAdapter.Protocol.Models;
using OmniSharp.Extensions.JsonRpc;
using OmniSharp.Extensions.JsonRpc.Generation;
using Thread = System.Threading.Thread;
Copy link
Contributor

@andyleejordan andyleejordan Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG this is all it was?! So this type came in and overrode the Thread in Protocol.Models...I was a bit confused by this when I brought in the update but didn't know how much of a worry it was PowerShell/PowerShellEditorServices@327061f

@david-driscoll david-driscoll merged commit 917c998 into OmniSharp:master Apr 22, 2021
@david-driscoll
Copy link
Member

Thanks @rjmholt

@github-actions github-actions bot added the mysterious We forgot to label this label Apr 22, 2021
@david-driscoll david-driscoll added this to the v0.19.2 milestone Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do the threads returned by a ThreadsHandler need to be real threads?
3 participants