Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Unicode characters in URIs .NET bug #196

Conversation

TylerLeonhardt
Copy link
Collaborator

@TylerLeonhardt TylerLeonhardt commented Dec 20, 2019

fixes #195

This adds some logic to better serialize file Uris. It also caught a few places where we weren't using the AbsoluteUriConverter.

@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review December 20, 2019 22:46
@bjorkstromm bjorkstromm force-pushed the workaround-unicode-characters-uri-bug branch from 7e05ad9 to 025a8d0 Compare December 30, 2019 21:53
@bjorkstromm bjorkstromm merged commit ad24c91 into OmniSharp:master Dec 30, 2019
@bjorkstromm
Copy link
Member

@TylerLeonhardt your changes have been merged! Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't rely on Uri.ToString() in Serializer
2 participants