Changes for #162 correct how text document sync settings are configured #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should hopefully fix some of the issues seen in #162 |
bjorkstromm
requested changes
Aug 19, 2019
| .Where(x => x.Change != TextDocumentSyncKind.None) | ||
| .Min(z => z.Change), | ||
| .Min(z => z.Change); |
There was a problem hiding this comment.
As per comment in #162 (comment) this seems to throw because sequence doesn't contain any elements. Maybe add the same predicate x => x.Change != TextDocumentSyncKind.None also to the if (options.Any()) check above?
There was a problem hiding this comment.
sounds like a good change...
|
@mholo65 updated 🙃 |
bjorkstromm
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.