Bring inputter split from master into native-markdown-improvements branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latter allowing language selection, smallcaps and underlining
And also a huge refactor/clean-up
7 tasks
alerque
force-pushed
the
native-markdown-improvements
branch
from
27d8ccd to
ced1e7f
Compare
|
The GitHub UI is not doing us any favors here. This is literally just 1 commit ahead of your branch—a merge from master with the relevant conflicts fixed so everything moves to the expected places. |
alerque
force-pushed
the
native-markdown-improvements
branch
from
ced1e7f to
cd32002
Compare
|
I just added a start to some busted tests to see if we get the AST we expect for a given input. The AST coming out of these seems to be nested a little deeper than it needs to be, but I haven't looked into it in detail yet. |
Omikhleia
force-pushed
the
native-markdown-improvements
branch
4 times, most recently
from
cbe64e9 to
dd81035
Compare
Omikhleia
force-pushed
the
native-markdown-improvements
branch
from
dd81035 to
6e56fb2
Compare
Omikhleia
reviewed
Jul 26, 2022
Omikhleia
reviewed
Jul 26, 2022
Omikhleia
force-pushed
the
native-markdown-improvements
branch
from
6e56fb2 to
dbc6e55
Compare
Omikhleia
force-pushed
the
native-markdown-improvements
branch
from
dbc6e55 to
eaeabad
Compare
|
I think I have taken into account most of the things from this PR in my last rebase, regarding the inputter/package split, etc. Keeping this PR open for now, however, as a reminder to check the busted test logic. |
Omikhleia
force-pushed
the
native-markdown-improvements
branch
from
104adae to
a154871
Compare
|
Main ideas from this PR used in the latest version => Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work I did to merge the core layout changes (notably having inputters be first class pluggable modules) into your work on the markdown class. See sile-typesetter#1481 for further comments.
Note especially the current usage for this would work like so:
With the inputter automatically setting up the markdown document class as part of it's hard coded AST.