Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window state error improvements and argument rename #141

Merged
merged 4 commits into from
Jun 17, 2019
Merged

Conversation

eeter
Copy link
Contributor

@eeter eeter commented Jun 13, 2019

Changes (backwards incompatible):

  • Error messages for keywords Window Should Be Maximized, Window Should Be Minimized and Window Should Be Restored changed to contain the actual state as Maximized, Minimized, or Restored instead of 0, 1, 2.
  • Window Should Be Restored optional argument renamed to match the other state verification keywords: window_title -> locator

Closes #125

@eeter eeter requested review from rasjani and Kompakti June 13, 2019 12:31
Copy link
Contributor

@rasjani rasjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if it makes any difference but i'd have kept the numeric output too just for scenarios where parsing the output and possible reacting into those would be a tiny tiny bit easier :)

Copy link
Contributor

@Kompakti Kompakti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@eeter eeter merged commit 51f0478 into master Jun 17, 2019
@eeter eeter deleted the window-error branch June 17, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message for window state verification keywords
3 participants