-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Background Animation #2092
Conversation
The build is failing on some of the linting tasks. ClientApp/app/settings/settings.module.ts[143, 32]: file should end with a newline |
@tidusjar Yes I think this is because the file in the develop branch does not end with a newline. Just double checked the branch from my fork and it's not causing the linting error. |
My bad! i'll take a look |
} | ||
|
||
public cycleBackground() { | ||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the this.timer
calls this.cycleBackground
every 10 seconds, and then we have another two timers in here?
Once that clears the background and another that sets it. Why do we have this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously I was running into sync issues therefore I added the timeout timers. With the new improvements I made they are redundant, will quickly push a new commit with the timers removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed the review request and made necessary changes
Nice! |
Implemented a background fade in/fade out on a ten second interval to cycle backgrounds on landing and login pages.