Emby Server - Item Details

[weberbox]

Describe the bug
Emby links (on search) are broken due to url change

To Reproduce
Steps to reproduce the behavior:

1. Open Ombi
2. Find a title tha is in Emby
3. Click on View on Emby
4. Page does not load

Expected behavior
Item is shown in Emby

Ombi Version (please complete the following information):

• Version 3.0.4680
• Media Server Emby

Additional context
Current link: http://app.emby.media/#!/itemdetails.html?id=[item id]
New link: http://app.emby.media/#!/item/item.html?id=[item id]

[ombi-bot]

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://github.com/tidusjar/ombi/wiki/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

[tidusjar]

Is this a URL change in Emby?

When did this happen?

[weberbox]

Yes this was a change with Emby server. I am not exactly sure when the change happened but very recently.

Emby server is version 4.2.0.32

[nesalkiN]

Same here. Running the Emby beta 4.2.0.34 so it could be only in beta for now..

[crxo1]

The URL is also changed in the 4.2.0.40 final release, which was released 7 days ago.

[nesalkiN]

Yep. I'm on latest stable now. The url has definitively changed. :)

[Aerion]

Just a note about Jellyfin, the open-source fork of Emby. If this issue were to be fixed, the item details wouldn't work on Jellyfin.

Jellyfin didn't change this route, it still uses itemdetails.html, so if the url were to change in Ombi, could it be configurable?

Currently, in the Emby configuration page, the parameter Externally Facing Hostname is used to specify the hostname used for configuring View on Emby hostname url. I suppose it could be also be used to specify if the user is using Emby (itemdetails.html) or Jellyfin/an older version of Emby (item/item.html).

[gcorgnet]

This says "merged" but it seems to still be broken in my current version (3.0.4740 - develop)
Do I need to wait for this to be included in a release?
Thanks

[yoriiis]

Hello, is there any news about this issue ? It is broken on the last release (3.0.4680).
Thanks

[VirtualValence]

still broken. Version 3.0.4680

[n1lsfps]

still broken

[aksiksi]

Can we get a minor release with this merged?

[tidusjar]

See above comments

[yoriiis]

I found the PR with the fix, it was merged into develop branch on 15 august 2019.
The detail is available here: e019402

Is it also possible to merged into master branch @tidusjar ?

[tidusjar]

The PR didn't seem to fully fix the issue. So if I merge it, it will still be broken

[tidusjar]

This has been fixed in the develop branch! 🎉 🎈