Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to plex functionality #1236

Closed
cardinalfan1 opened this issue Mar 12, 2017 · 2 comments
Closed

Link to plex functionality #1236

cardinalfan1 opened this issue Mar 12, 2017 · 2 comments

Comments

@cardinalfan1
Copy link

Ombi Version:

V 2.1.1336

Update Branch:

Stable

Media Sever:

Plex

Media Server Version:

1.4.3.3433

Operating System:

Ubuntu

Mono Version (only if your not on windows)

N/A

Applicable Logs (from /logs/ directory or the Admin page):

N/A

Problem Description:

"View in Plex" functionality is not working due to an incorrect URL being passed.

Reproduction Steps:

Hi, I'm just crossposting this from something I wrote in #544 , but since the issue was closed, wasn't sure if anyone would see it. I think I've identified the problem and the solution, but I don't have enough knowledge of github to actually try and fix it.

Thanks for implementing this feature. I have not been able to get it to work unfortunately. I tried getting my machine identifier from this site: https://plex.tv/pms/servers.xml. When I click on the "View in Plex" button, it takes me to a "You must be lost / This page doesn't exist".

For reference, the URL it is trying to take me to is: https://app.plex.tv/web/app#!/server/c5e18006a738bcc48bfef87e78f2c2d629851904/details/%2Flibrary%2Fmetadata%2F663

I tried changing the %2F to https://app.plex.tv/web/app#!/server/c5e18006a738bcc48bfef87e78f2c2d629851904/details//library/metadata/663
but this did not help either.

Any suggestions?

EDIT: Actually I just tried looking for what the correct URL should be, which is:
https://app.plex.tv/web/app#!/server/c5e18006a738bcc48bfef87e78f2c2d629851904/details?key=%2Flibrary%2Fmetadata%2F663

Is there any way to get the '?key=' part added on?
Thanks

EDIT 2: I think its Ombi/Ombi.Helpers/PlexHelper.cs, line 102 GetPlexMediaUrl...
If only I could figure out how to edit that file on my copy lol

public static string GetPlexMediaUrl(string machineId, string mediaId) { var url= $"https://app.plex.tv/web/app#!/server/{machineId}/details?key=library%2Fmetadata%2F{mediaId}"; return url; }

@Ombi-robot
Copy link

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Before posting make sure you also read our FAQ and known issues.
Make the title describe your issue. Having "not working" or "I get this bug" for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Cheers!
Ombi Support Team

Magikarplvl4 added a commit that referenced this issue Mar 12, 2017
Fixing the broken link to app.plex.tv for the "view in plex" button
@Magikarplvl4
Copy link
Contributor

@cardinalfan1 i pushed your report to the dev branch for a fix :)

tidusjar added a commit that referenced this issue Mar 13, 2017
Fixing #1236  the broken  link "view in plex" button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants