Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2057: Beta Result List + Thread UX #128

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

cjenkscybercom
Copy link
Contributor

@cjenkscybercom cjenkscybercom commented Dec 20, 2023

Summary of Changes

  • Adds features to the Beta UX:
    • search result list, with date-level grouping and pagination like in current ux
    • thread ux; replies displayed in-context of current entry, like in email clients. Reply sort order matches search result list sort order
    • sort direction moved to up/down arrow above search results
    • search box is currently stubbed, search has no filters; search ux to be addressed separately

Reminder: To run, use npm run start-beta if you don't activate the beta feature via environment variables.

Screenshot 2023-12-20 at 10 13 33

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom
Copy link
Contributor Author

e2e tests pass locally

Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "conversation view" we could consider to remove the "header" when an item is expanded. In attached screen shot the time stamp of header does not match the time stamp of the entry.

Screenshot 2023-12-20 at 13 16 00

@cjenkscybercom
Copy link
Contributor Author

In the "conversation view" we could consider to remove the "header" when an item is expanded. In attached screen shot the time stamp of header does not match the time stamp of the entry.

Screenshot 2023-12-20 at 13 16 00

That'd be a bit strange ux-wise, and buggy to do in MUIs Accordion api; accordions aren't meant to change dynamically.

That said, the dates should be the same...that part is strange, I'll look into it.

@georgweiss georgweiss self-requested a review December 20, 2023 13:59
@cjenkscybercom
Copy link
Contributor Author

Thanks for your review!
I've cleaned up date formatting in-general so they should all be consistent throughout the app, and we've added a background to the accordion summaries to make it clearer to users when they are viewing log details in the context of a thread or not (and may need to scroll down)

Screenshot 2023-12-20 at 16 06 00

@cjenkscybercom
Copy link
Contributor Author

e2e tests pass locally

Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cjenkscybercom cjenkscybercom merged commit 023cf67 into master Dec 20, 2023
3 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2057-beta-resultlist-conversations branch December 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants