Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add new placeholder for the file name #214

Closed
Majestry opened this issue Mar 12, 2021 · 4 comments
Closed

[FR] Add new placeholder for the file name #214

Majestry opened this issue Mar 12, 2021 · 4 comments
Labels
type: enhancement New feature or request

Comments

@Majestry
Copy link

It will be a nice feature to add new placholder, which will be replaced with the file name when sending to the printer.
For example, something like this
[current_print_filename]
Then the output the printer can be like progress is
[current_print_filename] progress is [progress]% L=[current_layer]/[total_layers]
@OllisGit OllisGit added status: inProgress type: enhancement New feature or request status: inNextRelease Will be implemented/fixed in next release and removed status: inProgress labels Apr 4, 2021
@OllisGit
Copy link
Owner

OllisGit commented Apr 4, 2021

Hi @Majestry,
fyi: will be in the next release.

BUT if you use this parameter in "Print Display", the M117 message could be really long. Be aware of this:
image

@Majestry
Copy link
Author

Majestry commented Apr 4, 2021

Cool! Thank you a lot!
Yes, i know about the long texts. Hoperfully, my printer just shows 64 symbols and simply cut other text. (Ender 3 v2 with Jyers firmware)

OllisGit pushed a commit that referenced this issue Apr 5, 2021
@OlafKa
New Version 1.26.0
307e3a4 
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
OllisGit pushed a commit that referenced this issue Apr 5, 2021
New Version 1.26.0
dc3f05d 
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
OllisGit added a commit that referenced this issue Apr 5, 2021
@OllisGit
New Version 1.26.0
41ad145 
E #214: current_print_filename placeholder
B #220: total height replaced by newly uploaded file
B #182: show clock after reload
@OllisGit
Copy link
Owner

OllisGit commented Apr 5, 2021

Hi @Majestry

new release 1.26.0 is out, please test and give feedback.

Thx, in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Apr 5, 2021
@Majestry
Copy link
Author

Majestry commented Apr 8, 2021 •
edited
Loading

Yes, it works.
Checked with latin file names
Printer display message in settings:
[current_print_filename] Layer [current_layer]/[total_layers]. Heigth [current_height]/[total_height]mm.
Printer display output (it's scrolling, so, all other texts are also there):
photo_2021-04-08_12-48-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Majestry @OllisGit