This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
♻️ migrate codebase to nullsafety #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding administrator displays "Unknown error" but adds the admin anyway - default profile pic doesn't show up in community . tapping on "new circle" in the "add user to connections" bottom sheet results in exception
|
If you'd like to help testing the app post-migration but don't want to build it yourself, you can use the following APK: https://s3-us-west-1.amazonaws.com/sallai/app-production-debug.apk (I don't have an iOS device, so I can't provide with an iOS build, sorry) 🎉 |
|
Uploaded a new apk with all of the bugs from the initial todo list fixed. The download link should be the same. |
|
Good job man! I'm going to test on the iOS now... |
|
Thanks @vituocgia! Lemme know if you've encountered any bugs! |
- updated dependencies to the newest non-breaking version - fixed android build compatibility issues - fixed compatibility issues with Flutter 2.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was/is a mostly manual migration*, so it's very likely that there are bugs here and there, but overall the migration is complete, now it's time for testing. I'm still testing as many features of the app as possible, to make sure everything works as intended. So far, apart from some smaller issues I've noticed, everything works fine. If you want to help debug things, you can build the app yourself report bugs back to me.
Sometimes there's some lag going on in the debug build** but that might be because it's not optimized and has a lot of debug symbols left in, which makes it slower.
When building the app, you have to use the
--no-sound-null-safetyflag for now, as some libraries are not yet migrated to support nullsafety (such as the OneSignal SDK). The vscode build tasks include this flag by default.*) I tried using the Dart migration tool but I couldn't get it to work at all. Also, I preferred to have this be manual for the most part, since trusting machines to automagically migrate such a large codebase is not necessarily a good idea because it could result in lots of debugging.
**) Haven't used the production build more thoroughly just yet.
P.S.: the oldest (largest) commit was originally split into multiple smaller commits, but I rebased it so it's all clean and tidy :)
Relevant issue: #546
Todo list
this very questionable overflow: https://i.imgur.com/fiqv7jM.jpg(we can prooooobably ignore this)