-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added embedding endpoint and tests #36
Conversation
thx for the quick response. i'll be testing today... |
some notes:
passed all tests, i think this is good to go. i have some updates that go after this to fix a few minor issues. |
Thanks for the input! I have updated the array to list to keep the convention. Regarding the model: According to this blog post the embedding V2 model should be used for majority of embedding use cases and is the one to use (It's supposed to be better AND cheaper, so I picked it as the main one). The previous models should still work as v1, but at the time writing this,I believe text-embedding-ada-002 is the only V2 model available. |
ok makes sense. i didn't add them, i read through that post also and since it was all released at the same time (jan 25, 2023) wasn't entirely clear to me. not sure if we should add just for completeness or leave as-is with the v2. either way the one you used works well, i didn't actually test a "comparison" of two vectors though. that would be nice to have as part of the tests eventually. |
after this is merged, i have a few minor tweaks, but will wait for merge first. |
Thanks @metjuperry for your help adding the embedding endpoint! I made some changes to align it with my updated endpoint and result inheritance style. Somehow it's now a new PR at #38 , I'm not sure why my additional commits didn't get added to this one. |
Added embedding endpoint and tests.
@gotmike